printSchema: support empty descriptions #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: bug fix 🐞
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 3, 2020
As of graphql/graphql-js#2177 in `graphql@15`, empty descriptions are still included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 3, 2020
As of graphql/graphql-js#2177 in `graphql@15`, empty descriptions are still included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 24, 2020
In `graphql@15`, empty descriptions are intentionally included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 29, 2020
* Adjust test to not use deprecated `introspectionQuery` constant. Instead, use `getIntrospectionQuery` instead, which has been around since before graphql@0.13.x, thus within our supported version ranges. * Adjust documentation links for moved `introspectionQuery` page. This file now lives at `getIntrospectionQuery`. * Applying upstream modification to `printDescription`. I'm assuming we'll want to keep this change which was also applied upstream, though I'm not sure what our longer term plans are for keeping up with these changes. Ref: https://github.com/graphql/graphql-js/pull/2177/files#diff-71ba52e9c625f826d2b0df2963c8633aR320 * Remove empty descriptions which will be included in SDL w/graphql@15. In `graphql@15`, empty descriptions are intentionally included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177
abernix
added a commit
to ardatan/graphql-tools
that referenced
this pull request
Apr 10, 2020
kamilkisiela
added a commit
to ardatan/graphql-tools
that referenced
this pull request
Apr 14, 2020
* Bump the minimum acceptable range for `apollo-link`. * v15: Unspecified descriptions are now `null` in the AST. Ref: graphql/graphql-js#2177 * Node 10 and 12 Co-authored-by: Jesse Rosenberger <git@jro.cc>
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
* Adjust test to not use deprecated `introspectionQuery` constant. Instead, use `getIntrospectionQuery` instead, which has been around since before graphql@0.13.x, thus within our supported version ranges. * Adjust documentation links for moved `introspectionQuery` page. This file now lives at `getIntrospectionQuery`. * Applying upstream modification to `printDescription`. I'm assuming we'll want to keep this change which was also applied upstream, though I'm not sure what our longer term plans are for keeping up with these changes. Ref: https://github.com/graphql/graphql-js/pull/2177/files#diff-71ba52e9c625f826d2b0df2963c8633aR320 * Remove empty descriptions which will be included in SDL w/graphql@15. In `graphql@15`, empty descriptions are intentionally included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177 Apollo-Orig-Commit-AS: apollographql/apollo-server@131c9b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.